rusackas commented on a change in pull request #12059:
URL:
https://github.com/apache/incubator-superset/pull/12059#discussion_r545716195
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -101,6 +106,7 @@ module.exports = {
'new-cap': 0,
'no-bitwise': 0,
'no-continue': 0,
+ 'no-console': 0,
Review comment:
I think we can set this to 1. We might even be able to set it to 2,
since people can ad an eslint-ignore comment when it's needed, or better yet
`import { logging } from '@superset-ui/core';` and do
`logging.log/info/warn/error/table`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
