ktmud commented on a change in pull request #11803:
URL:
https://github.com/apache/incubator-superset/pull/11803#discussion_r543898622
##########
File path: superset/cli.py
##########
@@ -40,6 +41,14 @@
logger = logging.getLogger(__name__)
+feature_flags = config.DEFAULT_FEATURE_FLAGS.copy()
+feature_flags.update(config.FEATURE_FLAGS)
+feature_flags_func = config.GET_FEATURE_FLAGS_FUNC
+if feature_flags_func:
+ # pylint: disable=not-callable
+ feature_flags = feature_flags_func(feature_flags)
Review comment:
This breaks the CLI when `feature_flags_func` uses `g.user` or any other
app context based variables.
```
RuntimeError: Working outside of application context.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
