ktmud commented on a change in pull request #11803:
URL:
https://github.com/apache/incubator-superset/pull/11803#discussion_r543901618
##########
File path: superset/cli.py
##########
@@ -40,6 +41,14 @@
logger = logging.getLogger(__name__)
+feature_flags = config.DEFAULT_FEATURE_FLAGS.copy()
+feature_flags.update(config.FEATURE_FLAGS)
+feature_flags_func = config.GET_FEATURE_FLAGS_FUNC
+if feature_flags_func:
+ # pylint: disable=not-callable
+ feature_flags = feature_flags_func(feature_flags)
Review comment:
I think we can just always add the command but do nothing or throw a
warning is a feature is not turned on, then we can use the default
`feature_flag_manager` as normal.
The part where you initialize feature flags differently is probably not
needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
