[GitHub] [incubator-superset] ktmud opened a new pull request #12116: fix: properly render booleans in FilterBox and explore page data preview

Fri, 18 Dec 2020 00:39:09 -0800 


ktmud opened a new pull request #12116:
URL: https://github.com/apache/incubator-superset/pull/12116


   ### SUMMARY
   
   Fixes #12106 #12105 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### After Fix
   
   In FilterBox:
   
   
![image](https://user-images.githubusercontent.com/335541/102593086-40851600-40c9-11eb-8c4e-5b3210e0fadd.png)
   
   In data preview:
   
   <img 
src="https://user-images.githubusercontent.com/335541/102592828-e71ce700-40c8-11eb-89d5-ee9c5ba2b850.png";
 width="600">
   
   ### TEST PLAN
   
   Manual verification.
   
   1. Try create a calculated column that returns boolean values in the 
`wb_health_population` dataset
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to