ktmud commented on a change in pull request #12116:
URL:
https://github.com/apache/incubator-superset/pull/12116#discussion_r545982183
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -216,7 +216,13 @@ class FilterBox extends React.PureComponent {
const color = 'lightgrey';
const backgroundImage = `linear-gradient(to right, ${color}, ${color}
${perc}%, rgba(0,0,0,0) ${perc}%`;
const style = { backgroundImage };
- return { value: opt.id, label: opt.id, style };
+ let label = opt.id;
+ if (label === true) {
+ label = t('True');
+ } else if (label === false) {
+ label = t('False');
Review comment:
I thought it made sense to translate as the FilterBox is a user-facing
interface, but I agree maybe more data-savvy users would want them to display
as what the database displays.
I'm going to extra them as constants so that customized Superset could
easily override.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
