agatapst opened a new pull request #12157:
URL: https://github.com/apache/incubator-superset/pull/12157


   ### SUMMARY
   "Reset all" button, located in Filter Bar, did not work. Now it is possible 
to click it - all previously set filters will be removed.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
![reset_all_before](https://user-images.githubusercontent.com/47450693/102788320-bd064600-43a2-11eb-8b3f-91b64a3350e6.gif)
   
   After:
   
![reset_all_after](https://user-images.githubusercontent.com/47450693/102788330-c099cd00-43a2-11eb-9936-2771667951b6.gif)
   
   ### TEST PLAN
   Set feature flag `DASHBOARD_NATIVE_FILTERS` to true.
   Go to Dashboards, choose one and set some filters in the Filter Bar.
   Click "Reset all" to check if all filters are removed and do not have an 
impact on charts.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @junlincc @villebro @rusackas 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to