villebro commented on a change in pull request #12157:
URL:
https://github.com/apache/incubator-superset/pull/12157#discussion_r546854305
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx
##########
@@ -399,6 +399,16 @@ const FilterBar: React.FC<FiltersBarProps> = ({
});
};
+ const handleResetAll = () => {
+ setFilterData({});
+ const filterIds = Object.keys(filterData);
+ filterIds.forEach(filterId => {
+ if (filterData[filterId]) {
+ setExtraFormData(filterId, {});
Review comment:
Not really relevant just yet as we don't have default values
implemented, but I wonder if "reset all" should reset to defaults or remove all
selected values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
