rusackas commented on a change in pull request #12122:
URL:
https://github.com/apache/incubator-superset/pull/12122#discussion_r547131263
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -78,6 +79,10 @@ const EditLockContainer = styled.div`
}
`;
+const StyledAlert = styled(Alert)`
+ margin-bottom: 20px;
Review comment:
```suggestion
margin-bottom: ${({ theme }) => theme.gridUnit * 5}px;
```
... if it's needed. It would be nice if these didn't need case-by-case style
overrides. If you suspect this will be a common occurrence, I'd rather add a
class name or prop to the Alert component itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
