rusackas commented on a change in pull request #12122:
URL:
https://github.com/apache/incubator-superset/pull/12122#discussion_r547132493
##########
File path: superset-frontend/src/datasource/DatasourceModal.tsx
##########
@@ -51,6 +51,11 @@ const StyledDatasourceModal = styled(Modal)`
}
`;
+const StyledAlert = styled(Alert)`
+ margin-top: ${({ theme }) => theme.gridUnit * 4}px;
+ margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
Review comment:
Again, I'm wondering if this is something that should be part of the
Alert itself (as a classname, or as a prop (which can be used by Emotion)).
Also, this one is 4 gridUnits bottom margin, where the DatasourceEditor one is
5 gridUnits. Hoping we can strive for consistency here, unless there are
special use cases floating around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
