nytai commented on a change in pull request #12189:
URL:
https://github.com/apache/incubator-superset/pull/12189#discussion_r547605886
##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -554,6 +554,7 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
const data: any = {
...currentAlert,
+ type: isReport ? 'Report' : 'Alert',
Review comment:
ensures correct type is always sent to api. There are various code paths
updating currentAlert, It's hard to tell which is causing this value to go out
of sync with the UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
