nytai commented on a change in pull request #12189:
URL:
https://github.com/apache/incubator-superset/pull/12189#discussion_r547618274
##########
File path: superset-frontend/src/views/CRUD/alert/AlertList.tsx
##########
@@ -183,10 +183,6 @@ function AlertList({
}
};
- useEffect(() => {
- refreshData();
- }, [isReportEnabled]);
-
Review comment:
This was causing duplicate api calls when switching back and forth
between alerts/reports. We no longer need this as baseFilters is changing which
results in a new fetchData, which triggers a new api call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
