nytai edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755787917


   @ktmud When we do eventually move to a single page app we can just do a 
`document.insertAdjacentHTML('beforeEnd', HTML_TEMPLATE_SCRIPT)` as part of the 
app initialization step in the preamble 
https://github.com/apache/superset/blob/8f7c7d43a3cfc71e5a58bbe317f65626f839f830/superset-frontend/src/preamble.ts#L32
   
   Or we can keep the current logic in the template we do end up using for all 
our views (assuming we haven't completely moved off flask/jinja) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to