nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553027183



##########
File path: superset/views/base.py
##########
@@ -333,6 +342,14 @@ def serialize_bootstrap_data() -> str:
     return {"bootstrap_data": serialize_bootstrap_data}
 
 
+@superset_app.context_processor
+def get_html_template_script() -> Dict[str, Any]:
+    def process_template_script() -> str:
+        return 
render_template_string(superset_app.config["HTML_TEMPLATE_SCRIPT"])

Review comment:
       call render_template_string incase HTML_TEMPLATE_STRING contains 
template variables

##########
File path: superset/views/base.py
##########
@@ -333,6 +342,14 @@ def serialize_bootstrap_data() -> str:
     return {"bootstrap_data": serialize_bootstrap_data}
 
 
+@superset_app.context_processor
+def get_html_template_script() -> Dict[str, Any]:
+    def process_template_script() -> str:
+        return 
render_template_string(superset_app.config["HTML_TEMPLATE_SCRIPT"])

Review comment:
       call render_template_string incase `HTML_TEMPLATE_STRING` contains 
template variables




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to