ktmud commented on pull request #12315: URL: https://github.com/apache/superset/pull/12315#issuecomment-755841589
My concern was more about how you would inject the tracking for SPA page transitions and other user events? You will eventually need a way to allow the inserted script to hook up to some page transition events or let the SPA call the tracking API. It doesn't seem worth it to add this tag to Jinja (which we are moving away) just to render a static script tag. Maybe we can add a `setupAppExtra.ts` file that custom deployments can override just like we did for `setupPluginsExtra` and `setupErrorMessagesExtra` (we may also consolidate these files into one). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
