rusackas commented on a change in pull request #12318:
URL: https://github.com/apache/superset/pull/12318#discussion_r553123202



##########
File path: superset-frontend/src/SqlLab/components/SouthPane.jsx
##########
@@ -59,6 +60,29 @@ const defaultProps = {
   offline: false,
 };
 
+const StyledPane = styled.div`
+  width: 100%;
+
+  .ant-tabs .ant-tabs-content-holder {

Review comment:
       This is probably not a battle for this PR, but when I see styles 
overriding AntD components, it makes me think there should probably be styling 
IN that component rather than here where it's used. In fact, this same sort of 
styling is happening in `superset-frontend/src/common/components/Tabs/Tabs.tsx` 
so there's probably some consolidation work to be done on this front. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to