rusackas commented on a change in pull request #12318:
URL: https://github.com/apache/superset/pull/12318#discussion_r553124162
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -555,6 +560,7 @@ export default class FilterableTable extends PureComponent<
style={{ height }}
className="filterable-table-container"
ref={this.container}
+ css={filterableTableStyles}
Review comment:
the css prop approach works, but I kind of lean toward the `styled.div`
implementation like you did with `StyledPane`. If you did that, you get the
bonus win of being able to kill this off from
`superset-frontend/src/SqlLab/main.less`:
```
.filterable-table-container {
margin-top: 48px;
}
```
... and switch it to `margin-top: ${({ theme }) => theme.gridUnit * 12}px;`
for a bonus bonus win ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
