nytai commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553680510
##########
File path: superset/templates/superset/basic.html
##########
@@ -104,5 +104,8 @@ <h4 data-test="modal-title" class="modal-title"></h4>
{{ js_bundle(entry) }}
{% endif %}
{% endblock %}
+ {% block custom_template %}
Review comment:
oh right, this is because we have one template
https://github.com/preset-io/incubator-superset/blob/0e31413fa36180a74febe6a17b00072907d3d62d/superset/templates/superset/crud_views.html#L24
that is overriding tail_js without calling super(). I think it has to do with
the menu already being included in that "app". I guess we could add the `{%
include "tail_js_custom_extra.html" %}` call in there too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
