ktmud commented on a change in pull request #12315:
URL: https://github.com/apache/superset/pull/12315#discussion_r553656316
##########
File path: superset/templates/superset/basic.html
##########
@@ -104,5 +104,8 @@ <h4 data-test="modal-title" class="modal-title"></h4>
{{ js_bundle(entry) }}
{% endif %}
{% endblock %}
+ {% block custom_template %}
Review comment:
Can we just move the `include` into `block tail_js` like in `base.html`?
I'm not sure why this file needs a new block but the other one does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
