nikolagigic opened a new pull request #12413:
URL: https://github.com/apache/superset/pull/12413


   ### SUMMARY
   Fix SaveModal dashboard select placeholder value and clear button.
   https://github.com/apache/superset/issues/12366
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
![104073894-b578d680-51c3-11eb-81c3-d2714db4bef6](https://user-images.githubusercontent.com/26679866/104220221-748cf600-543f-11eb-83b6-1a3a12ba7db3.png)
   After:
   ![Screenshot 2021-01-11 at 19 02 
48](https://user-images.githubusercontent.com/26679866/104220362-abfba280-543f-11eb-91c2-27e14e3f19bd.png)
   
   ### TEST PLAN
   1. **Open** or **create** any chart
   2. Click on **Save** button to save the chart
   
   **Expected result**: Under **ADD TO DASHBOARD** label, select dropdown 
should have a placeholder text with no clear button. If the value is selected, 
the value should be displayed instead of placeholder and clear button should 
appear.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to