ktmud commented on a change in pull request #12413:
URL: https://github.com/apache/superset/pull/12413#discussion_r555255868
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -29,7 +29,7 @@ import { connect } from 'react-redux';
// Session storage key for recent dashboard
const SK_DASHBOARD_ID = 'save_chart_recent_dashboard';
-const SELECT_PLACEHOLDER = t('**Select** a dashboard OR **create** a new one');
+const SELECT_PLACEHOLDER = t('Select dashboard');
Review comment:
Can we keep the original copy as I don't think we've added the
functionality to create a dashboard in the dropdown yet.
https://projects.invisionapp.com/share/V5VH03AHBER#/screens/399817652
cc @mihir174
For context, #10355 added this copy and there is a discussion on why this is
still not optimal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
