ktmud commented on a change in pull request #12411:
URL: https://github.com/apache/superset/pull/12411#discussion_r555289780
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -452,7 +455,13 @@ function ExploreViewContainer(props) {
<Icon name="dataset-physical" width={16} />
</div>
) : null}
- <div className="col-sm-3 explore-column controls-column">
+ <Resizable
+ defaultSize={{ width: 320 }}
+ minWidth={320}
+ maxWidth="33%"
Review comment:
Can we increase the maxWidth to somewhere around 50% to 60%? Sometimes
it's useful to test how the chart looks like when in very small containers.
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -452,7 +455,13 @@ function ExploreViewContainer(props) {
<Icon name="dataset-physical" width={16} />
</div>
) : null}
- <div className="col-sm-3 explore-column controls-column">
+ <Resizable
+ defaultSize={{ width: 320 }}
Review comment:
We should make this `width` persistent and save it in localStorage.
Could be in another PR, though.
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -404,7 +403,11 @@ function ExploreViewContainer(props) {
dashboardId={props.dashboardId}
/>
)}
- <div
+ <Resizable
+ defaultSize={{ width: 320 }}
+ minWidth={320}
Review comment:
I think the minWidth/default width for the Dataset column since it
somehow looks wider visually comparing to the Controls column, probably because
of the gray background or more white space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
