ktmud commented on a change in pull request #12411:
URL: https://github.com/apache/superset/pull/12411#discussion_r555303646
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -404,7 +403,11 @@ function ExploreViewContainer(props) {
dashboardId={props.dashboardId}
/>
)}
- <div
+ <Resizable
+ defaultSize={{ width: 320 }}
+ minWidth={320}
Review comment:
I think the minWidth/default width for the Dataset column can be smaller
since it somehow looks wider visually comparing to the Controls column,
probably because of the gray background or more whitespaces.
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -404,7 +403,11 @@ function ExploreViewContainer(props) {
dashboardId={props.dashboardId}
/>
)}
- <div
+ <Resizable
+ defaultSize={{ width: 320 }}
+ minWidth={320}
Review comment:
I think the minWidth/default width for the Dataset column can be smaller
since it somehow looks wider visually comparing to the Controls column,
probably because of the gray background or more empty space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
