betodealmeida opened a new pull request #12423:
URL: https://github.com/apache/superset/pull/12423


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   When using SQL Lab in Firefox, the position of the cursor will drift to the 
left progressively along the row. As the cursor moves to the right, it's 
shifted more and more to the left, to a point where it shows up in the 
incorrect position.
   
   This seems to be a known bug: 
https://stackoverflow.com/questions/20931029/ace-editor-monospace-fonts-issues-with-cursor-spacing
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   Here's a query in Firefox, with the cursor moved to the end of the line:
   
   ![Screenshot_2021-01-11 
Superset(1)](https://user-images.githubusercontent.com/1534870/104246558-15b58580-541b-11eb-8307-b27f8ae84aa7.png)
   
   Note how it looks like the cursor is to the left of the semi-colon — it's 
not, and if the user presses <key>delete</key> the semi-colon will be deleted 
instead!
   
   Here's the same query with this fix:
   
   ![Screenshot_2021-01-11 
Superset](https://user-images.githubusercontent.com/1534870/104246614-2f56cd00-541b-11eb-9d6e-6274e8ab6727.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to