eschutho commented on a change in pull request #12423:
URL: https://github.com/apache/superset/pull/12423#discussion_r555462771



##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -208,6 +208,10 @@ div.Workspace {
   .ace_content {
     height: 100%;
   }
+
+  .ace_editor * {
+    font: inherit!important;

Review comment:
       It seems that the issue is around the bolded typeface in Fira Code, with 
the same issue with Inter and monospace. The only one I was able to get to work 
was "Courier New" so far. Targeting just the bold text seems to work (nested 
under .ace_editor.ace_editor) if you don't want to change everything:
   ```  
   .ace_keyword {
       font-family: 'Courier New';
     }
   ```
   we could try out a few different common system fonts if you want to try to 
find a sans serif. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to