[GitHub] [superset] agatapst opened a new pull request #12465: fix(native-filters): Setting default value

Tue, 12 Jan 2021 10:01:13 -0800 


agatapst opened a new pull request #12465:
URL: https://github.com/apache/superset/pull/12465


   ### SUMMARY
   The aim of this PR was to improve setting default value for Native Filters. 
   The new Default Value Select component was created, which enables to choose 
default value based on dataset and field.
   Now it is possible to set default value for a given filter.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   
![default_values_before](https://user-images.githubusercontent.com/47450693/104353026-b1242480-5507-11eb-913f-6c5a223dec0e.gif)
   
   **After:
   for native filter without children (including editing)**
   
![defalult_value_normal_edit](https://user-images.githubusercontent.com/47450693/104353069-c13c0400-5507-11eb-9978-d4cc593afe35.gif)
   
   **for native filters child**
   
![default_value_children](https://user-images.githubusercontent.com/47450693/104353089-ca2cd580-5507-11eb-9d64-16e4994c225d.gif)
   
   ### TEST PLAN
   Go to `config.py` and set  `"DASHBOARD_NATIVE_FILTERS": True`
   Go to dashboards, choose one and create filter or use existing one.
   Set default value.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes one of the issues mentioned in #12148
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @junlincc @villebro @rusackas 
   @adam-stasiak could you test it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to