[GitHub] [superset] kkucharc opened a new pull request #12498: fix: row component handler is visible

Wed, 13 Jan 2021 09:04:55 -0800 


kkucharc opened a new pull request #12498:
URL: https://github.com/apache/superset/pull/12498


   ### SUMMARY
   In dashboard's edit mode menu with `delete` and `move` on left was cut by 
left end of page/browser.
   I made equal margin on both sides. The menu is closer the edited row.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   Left margin was more narrow than right one. 
   <img width="1341" alt="Screenshot 2021-01-13 at 17 47 17" 
src="https://user-images.githubusercontent.com/2536609/104482841-b6e13f00-55c7-11eb-83ed-2f1707cc5197.png";>
   
   Menu with `move` and `delete` in dashboard edit was truncated:
   <img width="969" alt="Screenshot 2021-01-13 at 17 47 37" 
src="https://user-images.githubusercontent.com/2536609/104482812-ad57d700-55c7-11eb-92eb-2f8656ec05f0.png";>
   
   **After:**
   _Without native filters:_
   Preview mode:
   ![Screenshot 2021-01-13 at 17 39 
47](https://user-images.githubusercontent.com/2536609/104483484-733b0500-55c8-11eb-977a-d539d1f3bd79.png)
   
   Edit mode:
   ![Screenshot 2021-01-13 at 17 39 
11](https://user-images.githubusercontent.com/2536609/104483450-6c13f700-55c8-11eb-9e41-49aafd7213c1.png)
   
   _With native filters:_
   Preview mode:
   ![Screenshot 2021-01-13 at 17 41 
36](https://user-images.githubusercontent.com/2536609/104483316-45ee5700-55c8-11eb-8b7e-29d12365a643.png)
   
   Edit mode:
   ![Screenshot 2021-01-13 at 17 42 
47](https://user-images.githubusercontent.com/2536609/104483325-4850b100-55c8-11eb-95cf-875b8d65576e.png)
   
   
   
   ### TEST PLAN
   1. Go to any dashboard and check margins
   1a. Go to edit mode of dashboard and try edit row of dashboard (on left 
there will be icon to delete or to move chart)
   
   To test native filters:
   Go to `supserset/config.py` and change `"DASHBOARD_NATIVE_FILTERS": False,` 
-> `"DASHBOARD_NATIVE_FILTERS": True,`
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: close: #12481
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc: @agatapst Can you take a look? I made some changes in your code.
   cc: @junlincc @adam-stasiak 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to