[GitHub] [superset] agatapst edited a comment on pull request #12498: fix: row component handler is visible

Thu, 14 Jan 2021 01:11:28 -0800 


agatapst edited a comment on pull request #12498:
URL: https://github.com/apache/superset/pull/12498#issuecomment-760057175


   @kkucharc regarding native filters:
   - when Filter Bar is hidden, the sidebar should look the same in Dashboard 
page and Explore page and it does 👍 
   Explore sidebar:
   ![Zrzut ekranu 2021-01-14 o 09 59 
46](https://user-images.githubusercontent.com/47450693/104567842-9066e680-564f-11eb-8505-90c2a23d8b2e.png)
   Dashboard sidebar:
   ![Zrzut ekranu 2021-01-14 o 09 59 
35](https://user-images.githubusercontent.com/47450693/104567872-9957b800-564f-11eb-93a1-642bacbb03d2.png)
   
   - when Filter Bar is open:
   in your PR:
   ![Zrzut ekranu 2021-01-14 o 10 05 
37](https://user-images.githubusercontent.com/47450693/104568321-3f0b2700-5650-11eb-8139-9ae6dcfc1f4b.png)
   
   master:
   ![Zrzut ekranu 2021-01-14 o 10 00 
04](https://user-images.githubusercontent.com/47450693/104568312-3a467300-5650-11eb-8677-69738669ac40.png)
   
   I can see there is bigger distance between Filter Bar and Dashboard in your 
PR, but in my opinion both versions look just fine. If the cost of smaller 
distance between Native Filter Bar and Dashboard are UI issues in some other 
component, then I am totally fine with it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to