betodealmeida opened a new pull request #12530:
URL: https://github.com/apache/superset/pull/12530


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR converts all column names in the new examples to lowercase, to 
ensure they work across different databases.
   
   This is necessary because in Postgresql columns with mixed case should be 
double quoted, but MySQL interprets double quoted values as strings.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   Using MySQL:
   
   ![Screenshot_2021-01-14 COVID Vaccine 
Dashboard(1)](https://user-images.githubusercontent.com/1534870/104660693-e782b080-567b-11eb-82c1-6ed8e8f38422.png)
   
   ![Screenshot_2021-01-14 Slack 
Dashboard](https://user-images.githubusercontent.com/1534870/104660706-ebaece00-567b-11eb-9dbe-9bd3eb0249af.png)
   
   ![Screenshot_2021-01-14 Sales 
Dashboard](https://user-images.githubusercontent.com/1534870/104660718-ef425500-567b-11eb-86a5-a48facc98753.png)
   
   ![Screenshot_2021-01-14 Sales 
Dashboard(1)](https://user-images.githubusercontent.com/1534870/104660725-f2d5dc00-567b-11eb-8571-dc96e099bc0f.png)
   
   ![Screenshot_2021-01-14 Video Game 
Sales](https://user-images.githubusercontent.com/1534870/104660738-fa958080-567b-11eb-9b1d-859144b67041.png)
   
   ![Screenshot_2021-01-14 Video Game 
Sales(1)](https://user-images.githubusercontent.com/1534870/104660746-fe290780-567b-11eb-86f8-51a5555b8e25.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018](https://user-images.githubusercontent.com/1534870/104660752-008b6180-567c-11eb-9d12-396af29f34ba.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(1)](https://user-images.githubusercontent.com/1534870/104660758-03865200-567c-11eb-917a-436622f1dec5.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(2)](https://user-images.githubusercontent.com/1534870/104660763-05e8ac00-567c-11eb-9570-0141035c81f6.png)
   
   Using Postgresql:
   
   ![Screenshot_2021-01-14 COVID Vaccine 
Dashboard(2)](https://user-images.githubusercontent.com/1534870/104662327-73e2a280-567f-11eb-97da-da74fd3bf4c4.png)
   
   ![Screenshot_2021-01-14 Slack 
Dashboard(1)](https://user-images.githubusercontent.com/1534870/104662337-793fed00-567f-11eb-924c-e948f346c3e2.png)
   
   ![Screenshot_2021-01-14 Sales 
Dashboard(2)](https://user-images.githubusercontent.com/1534870/104662348-7e04a100-567f-11eb-9940-481b046e3bc6.png)
   
   ![Screenshot_2021-01-14 Sales 
Dashboard(3)](https://user-images.githubusercontent.com/1534870/104662353-80ff9180-567f-11eb-8945-fc918aedd22d.png)
   
   ![Screenshot_2021-01-14 Video Game 
Sales(2)](https://user-images.githubusercontent.com/1534870/104662359-8361eb80-567f-11eb-9e23-68417ea705e4.png)
   
   ![Screenshot_2021-01-14 Video Game 
Sales(3)](https://user-images.githubusercontent.com/1534870/104662364-85c44580-567f-11eb-9cdd-6429c0e36385.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(3)](https://user-images.githubusercontent.com/1534870/104662368-88269f80-567f-11eb-920e-8c56322eae4a.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(4)](https://user-images.githubusercontent.com/1534870/104662375-8a88f980-567f-11eb-8ba7-4e06ad6d6f9d.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(5)](https://user-images.githubusercontent.com/1534870/104662384-8ceb5380-567f-11eb-8a89-2811f89af1c3.png)
   
   Using Sqlite:
   
   ![Screenshot_2021-01-14 COVID Vaccine 
Dashboard(3)](https://user-images.githubusercontent.com/1534870/104662748-5235eb00-5680-11eb-8658-305c7c45f272.png)
   
   ![Screenshot_2021-01-14 Slack 
Dashboard(2)](https://user-images.githubusercontent.com/1534870/104662752-5530db80-5680-11eb-82ba-c97f5f4ddb3c.png)
   
   ![Screenshot_2021-01-14 Sales 
Dashboard(4)](https://user-images.githubusercontent.com/1534870/104662766-58c46280-5680-11eb-919b-1e05837687f6.png)
   
   ![Screenshot_2021-01-14 Sales 
Dashboard(5)](https://user-images.githubusercontent.com/1534870/104662769-5a8e2600-5680-11eb-8e11-7adc37ef948e.png)
   
   ![Screenshot_2021-01-14 Video Game 
Sales(4)](https://user-images.githubusercontent.com/1534870/104662774-5c57e980-5680-11eb-8726-7ba834b87911.png)
   
   ![Screenshot_2021-01-14 Video Game 
Sales(5)](https://user-images.githubusercontent.com/1534870/104662778-5eba4380-5680-11eb-837b-ee832da87334.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(6)](https://user-images.githubusercontent.com/1534870/104662785-624dca80-5680-11eb-9f74-efd9a3879146.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(7)](https://user-images.githubusercontent.com/1534870/104662790-64178e00-5680-11eb-9f7f-64950715671e.png)
   
   ![Screenshot_2021-01-14 FCC New Coder Survey 
2018(8)](https://user-images.githubusercontent.com/1534870/104662794-65e15180-5680-11eb-8c5f-3b60bcfb5747.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   I installed Superset from scratch into 3 different databases, and tested the 
dashboards.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to