betodealmeida commented on a change in pull request #12530:
URL: https://github.com/apache/superset/pull/12530#discussion_r557827935
##########
File path: superset/examples/configs/charts/Filter_Segments.yaml
##########
@@ -23,32 +23,37 @@ params:
filter_configs:
- asc: true
clearable: true
- column: Ethnic Minority
+ column: ethnic_minority
key: -xNBqpfQo
+ label: Ethnic Minority
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: gender
key: 19VeBGTKf
+ label: Gender
multiple: true
searchAllOptions: false
- asc: true
clearable: true
- column: Developer Type
+ column: developer_type
key: OWTb4s69T
+ label: Developer Type
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: lang_at_home
key: Fn-YClyhb
+ label: Language at Home
multiple: true
searchAllOptions: false
- asc: true
clearable: true
column: country_live
key: 2fNskRCLJ
+ label: Country live
Review comment:
Good point, but TBH we might need to come up with something better.
@srinify what should be the label here? "Country currently living on"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
