eschutho commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557777589
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Update the limit dropdown with SQL_ROW_MAX value
+ const { maxRow } = this.props;
+ let currentLimit = LIMIT_DROPDOWN[LIMIT_DROPDOWN.length - 1];
+ while (currentLimit < maxRow) {
+ currentLimit *= 10;
+ LIMIT_DROPDOWN.push(currentLimit);
Review comment:
what if the limit is 999999... should we do `10 000` and then `999 999`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
