ktmud commented on pull request #12529: URL: https://github.com/apache/superset/pull/12529#issuecomment-760577667
It seems to me the original intention of adding a limit input is for preventing users from accidentally running long queries (either for database or for displaying in SQL lab). If that's the case, why not simplify things and make it a default-selected checkbox of "Limit 100" [like Mode does](https://mode.com/sql-tutorial/sql-limit/)?  This also avoids the confusion whether the limit number applies to the CSV or not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
