geido commented on a change in pull request #12593:
URL: https://github.com/apache/superset/pull/12593#discussion_r560348785
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -365,10 +365,20 @@ function ExploreViewContainer(props) {
);
}
+ function onResize(evt) {
+ const { x } = evt;
+ if (x > 0) {
+ localStorage.setItem('explore_sidebar_widths', x);
Review comment:
You might want to check that localStorage is available or catch eventual
errors. It might be disabled and will throw an exception in that case.
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -365,10 +365,20 @@ function ExploreViewContainer(props) {
);
}
+ function onResize(evt) {
+ const { x } = evt;
+ if (x > 0) {
+ localStorage.setItem('explore_sidebar_widths', x);
+ }
+ }
+
if (props.standalone) {
return renderChartContainer();
}
+ const exploreSidebarWidth =
+ localStorage.getItem('explore_sidebar_widths') || 320;
Review comment:
Same as my other comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
