rusackas commented on a change in pull request #12593:
URL: https://github.com/apache/superset/pull/12593#discussion_r560711039
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -404,7 +414,8 @@ function ExploreViewContainer(props) {
/>
)}
<Resizable
- defaultSize={{ width: 300 }}
+ onResize={onResize}
+ defaultSize={{ width: exploreSidebarWidth }}
Review comment:
I noticed SQL Lab is using localstorage without a try/catch safety net.
This PR makes me wonder if we should make an abstracted helper method, kind of
like the "logging" method from `@superset-ui/core`. These methods, maybe
`setStoredValue` and `getStoredValue, could try local storage, then try setting
a cookie, and take an optional callback for the `catch` block. I don't think we
need to get that crazy with this PR, but wonder if folks think it's an idea
worth ticketing separately.
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -404,7 +414,8 @@ function ExploreViewContainer(props) {
/>
)}
<Resizable
- defaultSize={{ width: 300 }}
+ onResize={onResize}
+ defaultSize={{ width: exploreSidebarWidth }}
Review comment:
I noticed SQL Lab is using localstorage without a try/catch safety net.
This PR makes me wonder if we should make an abstracted helper method, kind of
like the "logging" method from `@superset-ui/core`. These methods, maybe
`setStoredValue` and `getStoredValue`, could try local storage, then try
setting a cookie, and take an optional callback for the `catch` block. I don't
think we need to get that crazy with this PR, but wonder if folks think it's an
idea worth ticketing separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
