ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r562060939
##########
File path: superset-frontend/src/components/TableView/TableView.tsx
##########
@@ -51,7 +52,16 @@ const EmptyWrapper = styled.div`
const TableViewStyles = styled.div<{
isPaginationSticky?: boolean;
+ scrollTable?: boolean;
}>`
+ ${({ scrollTable, theme }) =>
+ scrollTable &&
+ `
+ height: 300px;
Review comment:
Should we make this height configurable, or use something like `40vh`
(40% of viewport height)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
