geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r562105157
##########
File path: superset-frontend/src/components/TableView/TableView.tsx
##########
@@ -51,7 +52,16 @@ const EmptyWrapper = styled.div`
const TableViewStyles = styled.div<{
isPaginationSticky?: boolean;
+ scrollTable?: boolean;
}>`
+ ${({ scrollTable, theme }) =>
+ scrollTable &&
+ `
+ height: 300px;
Review comment:
That's a good idea. However, there is some calculation to do to make
sure the height is just right for the modal to avoid showing its own scrollbar.
I'll keep this in mind for an enhancement and provide a separate PR for the
sake of getting this improvement in asap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
