amitmiran137 commented on a change in pull request #12668:
URL: https://github.com/apache/superset/pull/12668#discussion_r562447909
##########
File path: .github/workflows/scheduled_release.yml
##########
@@ -13,21 +13,15 @@ jobs:
- name: Checkout code
uses: actions/checkout@v2
- name: Get current date
- id: date
- run: echo "name=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
- - name: Test with environment variables
- run: echo $TAG_NAME - $RELEASE_NAME
- env:
- TAG_NAME: weekly-tag-${{ steps.date.outputs.date }}
- RELEASE_NAME: weekly-release-${{ steps.date.outputs.date }}
+ run: echo "::set-output name=todays_date::$(date +'%Y-%m-%d')"
- name: Create Release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
- tag_name: weekly-tag-${{ steps.date.outputs.date }}
- release_name: Reekly-release-${{ steps.date.outputs.date }}
+ tag_name: superset-1.0.0-${{ outputs.todays_date.value }}
+ release_name: superset-1.0.0-${{ outputs.todays_date.value }}
Review comment:
we could use [pybump](https://github.com/ArieLevs/PyBump) this can help
us manage the release version bumps automatically
we can do it in a follow-up PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
