eschutho commented on a change in pull request #12668:
URL: https://github.com/apache/superset/pull/12668#discussion_r562973505
##########
File path: .github/workflows/scheduled_release.yml
##########
@@ -13,21 +13,15 @@ jobs:
- name: Checkout code
uses: actions/checkout@v2
- name: Get current date
- id: date
- run: echo "name=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
- - name: Test with environment variables
- run: echo $TAG_NAME - $RELEASE_NAME
- env:
- TAG_NAME: weekly-tag-${{ steps.date.outputs.date }}
- RELEASE_NAME: weekly-release-${{ steps.date.outputs.date }}
+ run: echo "::set-output name=todays_date::$(date +'%Y-%m-%d')"
- name: Create Release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
- tag_name: weekly-tag-${{ steps.date.outputs.date }}
- release_name: Reekly-release-${{ steps.date.outputs.date }}
+ tag_name: superset-1.0.0-${{ outputs.todays_date.value }}
+ release_name: superset-1.0.0-${{ outputs.todays_date.value }}
Review comment:
You can try getting the latest release version from the tag. Something
like `git show-ref latest && git show --pretty=tformat:%d -s latest | grep
tag:` will give you a list of all tags on that sha, and you can parse through
them to get the one you want. There's an example of this in
`https://github.com/apache/superset/blob/master/scripts/tag_latest_release.sh`
I might also recommend adding something like "weekly-build" or "edge" to the
tag, or something so that people don't expect that this release is just a patch
on the last one.. there could be breaking changes for example, and we wouldn't
be bumping the semantic version on it at all to reflect that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
