bryanck commented on a change in pull request #12674:
URL: https://github.com/apache/superset/pull/12674#discussion_r563175027
##########
File path: superset/charts/commands/data.py
##########
@@ -82,6 +82,10 @@ def set_query_context(self, form_data: Dict[str, Any]) ->
QueryContext:
except ValidationError as error:
raise error
+ for query in self._query_context.queries:
+ if query.row_limit and query.metrics and not query.orderby:
+ query.orderby = [(query.metrics[0], False)]
Review comment:
That sounds reasonable, however the behavior of returning unordered
results in these cases seems to be a regression, as this wasn't happening in
v0.37. Perhaps the viz components changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
