bryanck commented on a change in pull request #12674:
URL: https://github.com/apache/superset/pull/12674#discussion_r564055186
##########
File path: superset/charts/commands/data.py
##########
@@ -82,6 +82,10 @@ def set_query_context(self, form_data: Dict[str, Any]) ->
QueryContext:
except ValidationError as error:
raise error
+ for query in self._query_context.queries:
+ if query.row_limit and query.metrics and not query.orderby:
+ query.orderby = [(query.metrics[0], False)]
Review comment:
I see. IMHO I feel like the best course of actions is to revert #11153,
also revert #12661 by me a few days ago, close this PR, and then open a ticket
to move order by to the charts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
