junlincc opened a new issue #12801:
URL: https://github.com/apache/superset/issues/12801


   currently, user can create a new metric in Edit dataset modal in Explore 
without sql expression, or without validating the new metric. 
   
   the new metrics becomes available in metric popover dropdown for user.  once 
it is selected and run query, users receive a non human readable or non 
actionable error message, which leads to a bad user experience.. It also would 
become problematic once drag and drop query control is available. 
   
   Proposed solution(shortterm): the modal should not allow user to save a 
metric without a VALID SQL expression. 
   Long term - will require redesigning this modal as a whole.... 
   
   
https://user-images.githubusercontent.com/67837651/106103648-1f670a80-60f6-11eb-9637-8b67553c53df.mov
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to