amitmiran137 edited a comment on pull request #12680: URL: https://github.com/apache/superset/pull/12680#issuecomment-769007188
I must add that I tried forcing the fixture approach here by trying to have a "create new user" fixture for every test but it seems like I can't get the user created as an inject parameter to the test method bc we uses class based testing and not purely pytest in native syntax The fixtures superset is using focus on the setup/teardown events but they don't provide a way to inject parameter to test methods The tests here also uses the same approach of constructing and destructing objects with a have a dashboardTestUtils and base classes that provide all the common actions need to be done around the Dashboard domain The advantage of a utils that you can customize how you use it within each test instead of forcing working from a decorator only I hope you like it 🤞 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
