amitmiran137 commented on a change in pull request #12680: URL: https://github.com/apache/superset/pull/12680#discussion_r566195151
########## File path: tests/dashboards/base_case.py ########## @@ -0,0 +1,114 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import json +from typing import Any, Dict, Union + +import prison +from flask import Response + +from superset import app, security_manager +from tests.base_tests import SupersetTestCase +from tests.dashboards.consts import * +from tests.dashboards.dashboard_test_utils import build_save_dash_parts +from tests.dashboards.superset_factory_util import delete_all_inserted_objects + + +class DashboardTestCase(SupersetTestCase): Review comment: I've looked into alerts_tests.py I understand its usefulles use by parameterizing the scenarios and I like it. but, it seems to be using https://docs.pytest.org/en/stable/yieldfixture.html which seems to be deprecated is it still the right way to go? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
