amitmiran137 edited a comment on pull request #12680: URL: https://github.com/apache/superset/pull/12680#issuecomment-769611063
> This is amazing! Thank you so much for the comprehensive test cases. > > It seems this PR did not apply RBAC restriction on [the Dashboard page](https://github.com/apache/superset/blob/55c8f9ba600b1de4f8ed08db6a5ff7ab2d33924f/superset/views/core.py#L1783), will it be in a separate PR? Thank you @ktmud Up until now there were no restrictions at all on the dashboard page and it is accessible with some basic permissions So yes, Follow up PR will enforce the same standard just for a single dashboard ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
