ktmud commented on a change in pull request #12680:
URL: https://github.com/apache/superset/pull/12680#discussion_r566370156
##########
File path: tests/base_tests.py
##########
@@ -289,19 +294,39 @@ def get_access_requests(self, username, ds_type, ds_id):
def logout(self):
self.client.get("/logout/", follow_redirects=True)
+ def grant_access_to_dashboard(self, dashboard, role_name):
+ role = security_manager.find_role(role_name)
+ dashboard.roles.append(role)
+ db.session.merge(dashboard)
+ db.session.commit()
Review comment:
These class methods can probably be moved to standalone functions
somewhere since they don't rely on `self`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
