simcha90 commented on a change in pull request #12858:
URL: https://github.com/apache/superset/pull/12858#discussion_r567674807
##########
File path: superset-frontend/src/preamble.ts
##########
@@ -74,3 +75,8 @@ setupColors(extraCategoricalColorSchemes,
extraSequentialColorSchemes);
// Setup number formatters
setupFormatters();
+
+export const customTheme = merge(
+ supersetTheme,
+ bootstrapData?.common?.custom_theme ?? {},
+);
Review comment:
we did in order to not enforce users override entire theme, so he can
override just some props and other will be taken by default, because in other
case some code can throw error that can't find some deep property in theme...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
