villebro commented on a change in pull request #12858:
URL: https://github.com/apache/superset/pull/12858#discussion_r567680383
##########
File path: superset-frontend/src/preamble.ts
##########
@@ -74,3 +75,8 @@ setupColors(extraCategoricalColorSchemes,
extraSequentialColorSchemes);
// Setup number formatters
setupFormatters();
+
+export const customTheme = merge(
+ supersetTheme,
+ bootstrapData?.common?.custom_theme ?? {},
+);
Review comment:
Yes I'm not proposing not merging, but rather renaming it, as without
any overrides it's not really a custom theme, but rather just the default
theme. So the way I see it `theme = supersetTheme + themeOverrides` (pseudocode)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
