ktmud commented on a change in pull request #12903:
URL: https://github.com/apache/superset/pull/12903#discussion_r568987699
##########
File path: .github/workflows/bashlib.sh
##########
@@ -167,7 +167,8 @@ cypress-run() {
if [[ -z $CYPRESS_KEY ]]; then
$cypress --spec "cypress/integration/$page" --browser "$browser"
else
- export CYPRESS_RECORD_KEY=`echo $CYPRESS_KEY | base64 --decode`
+ CYPRESS_RECORD_KEY=$(echo "$CYPRESS_KEY" | base64 --decode)
+ export CYPRESS_RECORD_KEY
Review comment:
Bycatch: fix lint errors
##########
File path:
superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
##########
@@ -122,119 +121,6 @@ describe('VizType control', () => {
});
});
-describe('Time range filter', () => {
Review comment:
Moved to a separate file. No functional change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
