[GitHub] [superset] ktmud opened a new pull request #12903: fix(explore): hide time section for datasets with no time column

[GitBox]

ktmud opened a new pull request #12903:
URL: https://github.com/apache/superset/pull/12903


   ### SUMMARY
   
   This could be a somewhat controversial feature, but it doesn't seem to make 
much sense to display the Time section when the datasource has no time columns 
available. Shall we hide it when these datasources?
   
   One downside of this is that the granularity and time range will reset to 
default when users change to a non-timeseries dataset then change it back to a 
timeseries dataset. The benefit is cleaner UI and less clutters for 
non-timeseries datasets.
   
   #### Before
   
   <img width="1101" alt="energy-use-yes-time" 
src="https://user-images.githubusercontent.com/335541/106671932-14800000-6564-11eb-83da-c0a21b33f150.png";>
   
   
   #### After
   
   <img width="1107" alt="energy-use-no-time" 
src="https://user-images.githubusercontent.com/335541/106671846-f1ede700-6563-11eb-9810-ab15024bc13b.png";>
   
   
   ### TEST PLAN
   
   Manual verification:
   
   1. Open "Explore" in datasets with and without a time column
   2. Make sure both cases work
   
   I also added some Cypress tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: 
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org