ktmud opened a new pull request #12905: URL: https://github.com/apache/superset/pull/12905
### SUMMARY This is probably a little controversial, too. Sometimes chart plugin `buildQuery` generates invalid `null` values for certain props (either because of sloppy code or uncleaned legacy data), making the whole query fails:  Since most of the props are optional anyway, maybe we should just make the backend more error-tolerant by allowing `null` (`None`) everywhere possible. ### TEST PLAN Manually tested by sending API request with null values to `/api/v1/chart/data` ```json { "datasource": { "id": 27, "type": "table" }, "force": false, "queries": [ { "time_range": null, "filters": null, "columns": [ "season", "episode", "TITLE" ], "metrics": null, "orderby": null, "row_limit": null, "timeseries_limit": null, "order_desc": null, "url_params": null, "post_processing": null } ], "result_format": "json", "result_type": "full" } ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
