ktmud commented on a change in pull request #12905:
URL: https://github.com/apache/superset/pull/12905#discussion_r569050297
##########
File path: superset/charts/schemas.py
##########
@@ -873,18 +873,20 @@ class Meta: # pylint: disable=too-few-public-methods
)
applied_time_extras = fields.Dict(
description="A mapping of temporal extras that have been applied to
the query",
- required=False,
+ allow_none=True,
example={"__time_range": "1 year ago : now"},
)
- filters = fields.List(fields.Nested(ChartDataFilterSchema), required=False)
+ filters = (fields.List(fields.Nested(ChartDataFilterSchema),
allow_none=True),)
Review comment:
It is not. Accidentally ddded an extra comma then Pylint autoformatting
made it a tuple.
Thanks for catching it!
##########
File path: superset/charts/schemas.py
##########
@@ -873,18 +873,20 @@ class Meta: # pylint: disable=too-few-public-methods
)
applied_time_extras = fields.Dict(
description="A mapping of temporal extras that have been applied to
the query",
- required=False,
+ allow_none=True,
example={"__time_range": "1 year ago : now"},
)
- filters = fields.List(fields.Nested(ChartDataFilterSchema), required=False)
+ filters = (fields.List(fields.Nested(ChartDataFilterSchema),
allow_none=True),)
Review comment:
It is not. Accidentally added an extra comma then Pylint autoformatting
made it a tuple.
Thanks for catching it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
